lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] Updated: (LUCENE-2717) BasicOperations.concatenate creates invariants
Date Thu, 21 Oct 2010 19:06:28 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Robert Muir updated LUCENE-2717:
--------------------------------

    Attachment: LUCENE-2717.patch

here's the fix.

the problem is if you concatenate empty with any automaton, the result must be empty.

so if the RHS was empty, the concatenation was "correct" but it would 
create epsilon transitions from the LHS's accept states all to dead states...

in the fix i just return makeEmpty() if either is empty, which is a very quick check.

will commit soon.


> BasicOperations.concatenate creates invariants
> ----------------------------------------------
>
>                 Key: LUCENE-2717
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2717
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-2717.patch, LUCENE-2717.patch
>
>
> I started writing a test for LUCENE-2716, and i found a problem with BasicOperations.concatenate(Automaton,
Automaton):
> it creates automata with invariant representation (which should never happen, unless
you manipulate states/transitions manually).
> strangely enough the BasicOperations.concatenate(List<Automaton>) does not have
this problem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message