lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Hatcher (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-2168) Velocity facet output for facet missing
Date Sun, 17 Oct 2010 12:01:24 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921831#action_12921831
] 

Erik Hatcher commented on SOLR-2168:
------------------------------------

I've taken the patch idea and gave it a slight modification.  In my effort to learn git, I've
committed it to my "facet_missing" branch here: http://github.com/erikhatcher/lucene-solr/commit/70197cca24129141081d83ea422515dc69287e73
 (I've still got to figure out how to push this change to Solr's trunk through git)

I changed the code to so that the #set wasn't needed and also changed the label shown for
missing facets to <No $field.name> to have angle brackets to avoid it looking like a
regular value.  These changes ok with you?   (I also cleaned up the formatting of that file
slightly)

Out of curiosity, what's annoying about Velocity syntax?  (for example, show me how it'd look
in your template language of choice)

> Velocity facet output for facet missing
> ---------------------------------------
>
>                 Key: SOLR-2168
>                 URL: https://issues.apache.org/jira/browse/SOLR-2168
>             Project: Solr
>          Issue Type: Bug
>          Components: Response Writers
>    Affects Versions: 3.1
>            Reporter: Peter Wolanin
>            Priority: Minor
>         Attachments: SOLR-2168.patch
>
>
> If I add fact.missing to the facet params for a field, the Veolcity output has in the
facet list:
> $facet.name (9220)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message