lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (JIRA)" <j...@apache.org>
Subject [jira] Updated: (SOLR-2179) unregistered searchers not closed
Date Wed, 20 Oct 2010 00:57:26 GMT

     [ https://issues.apache.org/jira/browse/SOLR-2179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Yonik Seeley updated SOLR-2179:
-------------------------------

    Attachment: SOLR-2179.patch

Basically, the idea is to wait for the search executor to finish before closing the main searcher.

Here's the patch:
 - closes the search executor before closing the last registered searcher
 - moves the close hook calls first, and catches any exceptions thrown by them

New comments in the code explain a little more:
{code}
+      // Since we waited for the searcherExecutor to shut down,
+      // there should be no more searchers warming in the background
+      // that we need to take care of.
+      //
+      // For the case that a searcher was registered *before* warming
+      // then the searchExecutor will throw an exception when getSearcher()
+      // tries to use it, and the exception handling code should close it.
+      closeSearcher();
{code}

> unregistered searchers not closed
> ---------------------------------
>
>                 Key: SOLR-2179
>                 URL: https://issues.apache.org/jira/browse/SOLR-2179
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>         Attachments: SOLR-2179.patch
>
>
> A searcher that has not yet been registered is not tracked anywhere and may not be closed
if the core is closed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message