lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2662) BytesHash
Date Fri, 01 Oct 2010 13:23:34 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916885#action_12916885
] 

Simon Willnauer commented on LUCENE-2662:
-----------------------------------------

bq. Simon, thank you for renaming the 'utf8' variables here.
YW :)

bq. In RecyclingByteBlockAllocator.recycleByteBlocks, if we cannot recycle all of the blocks
(ie because it exceeds maxBufferedBlocks), we are failing to null out the entries in the incoming
array?
Ahh you are right - I will fix. 

bq. Also maybe rename pos -> freeCount? (pos is a little too generic?)
I mean its internal though but I see your point.

thanks for reviewing it closely. 

{quote}
The avgUsedMem was quite a bit higher (1.5GB vs 1.0GB), but, I'm not sure this stat is trustworthy....
I'll re-run w/ infoStream enabled to see if anything looks suspicious (eg, we are somehow
not tracking bytes used correctly).
{quote}

hmm I will dig once I get back to my workstation.

simon

> BytesHash
> ---------
>
>                 Key: LUCENE-2662
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2662
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: Realtime Branch, 4.0
>            Reporter: Jason Rutherglen
>            Assignee: Simon Willnauer
>            Priority: Minor
>             Fix For: Realtime Branch, 4.0
>
>         Attachments: LUCENE-2662.patch, LUCENE-2662.patch, LUCENE-2662.patch, LUCENE-2662.patch,
LUCENE-2662.patch
>
>
> This issue will have the BytesHash separated out from LUCENE-2186

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message