lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <>
Subject [jira] Commented: (LUCENE-2618) Intermittent failure in 3.x's backwards TestThreadedOptimize
Date Thu, 21 Oct 2010 19:20:16 GMT


Shai Erera commented on LUCENE-2618:

I don't personally mind either way. Just want to point out that calling maybeMerge is as explicit
as calling optimize. You can argue for both that if an app wants to wait for merges it can
call waitForMerges. In fact, an app calling close() already stated it wants to wait for merges
- it's as if it called waitForMerges followed by close.

I think you're trying to distinguish merges that started because the MP decided they should
run following a certain commit to those triggered by explicit call to optimize. So IMO maybeMerge
and optimize are the same as both were explicitly initiated by the application.

This test fails because it assumes optimize will run to completion. What if the test assumed
maybeMerge runs to completion? Isn't that a valid expectation from an application calling
close()? We're also distinguishing the first round of merges from subsequent rounds, only
when maybeMerge is called, but not optimize...

> Intermittent failure in 3.x's backwards TestThreadedOptimize
> ------------------------------------------------------------
>                 Key: LUCENE-2618
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>            Reporter: Michael McCandless
>             Fix For: 3.1, 4.0
>         Attachments: LUCENE-2618.patch
> Failure looks like this:
> {noformat}
>     [junit] Testsuite: org.apache.lucene.index.TestThreadedOptimize
>     [junit] Testcase: testThreadedOptimize(org.apache.lucene.index.TestThreadedOptimize):
>     [junit] null
>     [junit] junit.framework.AssertionFailedError: null
>     [junit] 	at org.apache.lucene.index.TestThreadedOptimize.runTest(
>     [junit] 	at org.apache.lucene.index.TestThreadedOptimize.testThreadedOptimize(
>     [junit] 	at org.apache.lucene.util.LuceneTestCase.runBare(
> {noformat}
> I just committed some verbosity so next time it strikes we'll have more details.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message