lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Grant Ingersoll (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-2187) Provide more DirectoryFactory implementations for the various different Directories
Date Fri, 22 Oct 2010 18:20:05 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923954#action_12923954
] 

Grant Ingersoll commented on SOLR-2187:
---------------------------------------

bq. enable the unmapHack if its supported (MMapDirectory.UNMAP_SUPPORTED). This is the default
in 4.x, but not in 3.x. Might want to do this one by default, if its supported.

What do you think should be the behavior if setting it fails?  Should we fail completely (i.e.
let the exception percolate up) or should we catch it, log it and still provide the MMapDirectory,
just w/o the unmap.  Seems like, in this case, we should just log it, but others are often
of the opinion that we should fail for these kinds of things.


> Provide more DirectoryFactory implementations for the various different Directories
> -----------------------------------------------------------------------------------
>
>                 Key: SOLR-2187
>                 URL: https://issues.apache.org/jira/browse/SOLR-2187
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>             Fix For: 3.1, 4.0
>
>         Attachments: SOLR-2187.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message