Return-Path: Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: (qmail 49345 invoked from network); 17 Sep 2010 18:02:07 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 17 Sep 2010 18:02:07 -0000 Received: (qmail 66685 invoked by uid 500); 17 Sep 2010 18:02:06 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 66645 invoked by uid 500); 17 Sep 2010 18:02:05 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 66638 invoked by uid 99); 17 Sep 2010 18:02:05 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Sep 2010 18:02:05 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Sep 2010 18:02:05 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o8HI1i6e017367 for ; Fri, 17 Sep 2010 18:01:44 GMT Message-ID: <27507522.256201284746504003.JavaMail.jira@thor> Date: Fri, 17 Sep 2010 14:01:44 -0400 (EDT) From: "Yonik Seeley (JIRA)" To: dev@lucene.apache.org Subject: [jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs In-Reply-To: <3738400.244411284693932822.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910699#action_12910699 ] Yonik Seeley commented on LUCENE-2649: -------------------------------------- bq. Let's try to find some baby-step (even if not clean - we know FieldCache, somehow, needs to be fixed more generally) for today? The cheapest option might be: {quote} public interface Parser extends Serializable { public boolean recordMissing(); } {quote} A better option is to replace FieldCache.Parser in SortField to be FieldCache.EntryCreator. Oh, and if we're recording all the set bits, it would be really nice to record both - the number of values set - the number of unique values encountered Both should be zero or non-measurable cost (a counter++ that does not produce a data dependency can be executed in parallel on a free int execution unit) > FieldCache should include a BitSet for matching docs > ---------------------------------------------------- > > Key: LUCENE-2649 > URL: https://issues.apache.org/jira/browse/LUCENE-2649 > Project: Lucene - Java > Issue Type: Improvement > Reporter: Ryan McKinley > Fix For: 4.0 > > Attachments: LUCENE-2649-FieldCacheWithBitSet.patch, LUCENE-2649-FieldCacheWithBitSet.patch, LUCENE-2649-FieldCacheWithBitSet.patch > > > The FieldCache returns an array representing the values for each doc. However there is no way to know if the doc actually has a value. > This should be changed to return an object representing the values *and* a BitSet for all valid docs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org