Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Message-ID: <16243783.40241283779352970.JavaMail.jira@thor>
Date: Mon, 6 Sep 2010 09:22:32 -0400 (EDT)
From: "Yonik Seeley (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Subject: [jira] Commented: (SOLR-2100) Fix for saving commit points during
 java-based backups
In-Reply-To: <17349373.16181283538814173.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/SOLR-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906505#action_12906505 ] 

Yonik Seeley commented on SOLR-2100:
------------------------------------

bq. but will it still save the commit point for replication even if another commit (or many commits) come along during replication? 

Yes.... that's what the reservation system is for.  When someone asks us for the current  index version, we reserve that version for some amount of time and return that.  When the client is retrieving a file, they also specify what index version it is for so we can periodically renew the reservation during streaming back.

If we didn't use a reservation system, a client could ask for the index version, die, and then we would save it forever.

> Fix for saving commit points during java-based backups
> ------------------------------------------------------
>
>                 Key: SOLR-2100
>                 URL: https://issues.apache.org/jira/browse/SOLR-2100
>             Project: Solr
>          Issue Type: Bug
>          Components: replication (java)
>    Affects Versions: 1.4, 1.4.1
>            Reporter: Peter Sturge
>            Priority: Minor
>             Fix For: 1.4.2
>
>         Attachments: SOLR-2100.PATCH
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> This patch fixes the saving of commit points during backup operations.
> This fixes the perviously commited (for 1.4) SOLR-1475 patch.
> 1. In IndexDeletionPolicyWrapper.java, commit points are not saved to the 'savedCommits' map.
> 2. Also, the testing of the presence of a commit point uses the contains() method instead of containsKey().
> The result of this means that backups for anything but toy indexes fail, because the commit points are deleted (after 10s) before the full backup is completed.
> This patch addresses these 2 issues.
> Tested with 1.4.1 release trunk, but should also work fine with 1.4.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org