lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robert Muir <rcm...@gmail.com>
Subject Re: Build failed in Hudson: Solr-3.x #111
Date Thu, 23 Sep 2010 15:27:26 GMT
On Thu, Sep 23, 2010 at 11:21 AM, Chris Hostetter
<hossman_lucene@fucit.org>wrote:

>
> Wild guess: it's coming from a test that seems to deal with dates -- maybe
> it's code that uses a DateFormatter (parsing or formating) in a
> non-ThreadSafe way?
>

possibly, good idea: i will apply some pressure to the test (-Dtests.iter)
and see what happens


>
> in which case it may be likely to show up in parallel tests but not when
> running tests individually
>

just for reference: our "parallel" tests are not "parallel" with threads but
completely separate JVMs.
so tests don't need to be thread-safe.

Example:
TestClassA, TestClassB, TestClassC, TestClassD

with 2 "threads" we just spawn 2 jvms (jvm1 and jvm2):
jvm1 executes TestClassA, then TestClassB
jvm2 exectues TestClassC, then TestClassD

the other thing "parallel tests" do is give jvm1 and jvm2 unique base temp
directories, so that if they are working with the filesystem they wont step
over each other.

so parallel tests are rather safe, but we do have to be aware of statics
(since jvm1 will run TestClassA, then TestClassB sequentially in the same
jvm)

-- 
Robert Muir
rcmuir@gmail.com

Mime
View raw message