lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrzej Bialecki (JIRA)" <>
Subject [jira] Commented: (LUCENE-2638) Make HighFreqTerms.TermStats class public
Date Mon, 13 Sep 2010 19:01:37 GMT


Andrzej Bialecki  commented on LUCENE-2638:

I use this class in Luke, which admittedly is not a common use case ;) I guess you could use
it also to obtain a list of common words that are good candidates for shingling in the future
(the "common grams" method).

Anyway, as it is now the API is simply inconsistent - public methods return instances of a
package-private class - so either we close the API completely, or we take this small additional
step to open it for other creative uses.

Actually, I'm inclined to make this a static inner class instead of a separate class, to avoid
polluting the package with classes that are not tools.

> Make HighFreqTerms.TermStats class public
> -----------------------------------------
>                 Key: LUCENE-2638
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 4.0
>            Reporter: Andrzej Bialecki 
>         Attachments: LUCENE-2638.patch
> It's not possible to use public methods in contrib/misc/... /HighFreqTerms from outside
the package because the return type has package visibility. I propose to move TermStats class
to a separate file and make it public.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message