lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <>
Subject [jira] Commented: (SOLR-792) Tree Faceting Component
Date Thu, 09 Sep 2010 01:24:50 GMT


Hoss Man commented on SOLR-792:

1) ...

bq. Moves the parameter defines to

i'm not sure where they were in the original patch, but i really think they should be in their
own PivotFacetParams class (just as having this be a distinct SearchComponent from the existing
bloated FacetComponet is nice and keeps things manageable, having the params in a separate
class is also nice ... i hope to get around to refactoring FacetComponent into oblivion someday)

2) when i was working on Range Faceting (superset of DateFaceting) yonik pointed out that
having the metadata mixed with the counts (like date faceting used) was a bad idea, and that
we should really have a "counts" sub list for managing the actual counts, and keep the meta-data
at the top level.  with that in mind, i think what you have in your latest example looks great
-- i would just suggest that we rename the "pivot" key to "counts" for consistency, and then
rename the "count" key to something else ("total" or "total-count" perhaps?)

3) the one thing that still kind of bugs me about this components param structure is the way
it takes in a comma seperated list of field names and then uses that comma seperated list
as the "key" in the response.  I'm wondering if a URL structure like this would be better...


...where "my_name" then becomes the response key under the "facet_pivot" list?

that way we don't add any more features that break if you have some special character in a
field name

> Tree Faceting Component
> -----------------------
>                 Key: SOLR-792
>                 URL:
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Erik Hatcher
>            Assignee: Erik Hatcher
>            Priority: Minor
>         Attachments: SOLR-792-PivotFaceting.patch, SOLR-792.patch, SOLR-792.patch, SOLR-792.patch,
SOLR-792.patch, SOLR-792.patch, SOLR-792.patch
> A component to do multi-level faceting.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message