lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2643) StringHelper#stringDifference is wrong about supplementary chars
Date Tue, 14 Sep 2010 14:04:35 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909253#action_12909253
] 

Robert Muir commented on LUCENE-2643:
-------------------------------------

My vote would be to drop it if we arent using it, its @lucene.internal.

since its unused, its not obvious that its "wrong" (its correct if you want the first code
unit difference)


> StringHelper#stringDifference is wrong about supplementary chars 
> -----------------------------------------------------------------
>
>                 Key: LUCENE-2643
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2643
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.0, 3.0.1, 3.0.2
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Trivial
>             Fix For: 3.0.3, 3.1, 4.0
>
>         Attachments: LUCENE-2643.patch
>
>
> StringHelper#stringDifference does not take supplementary characters into account. Since
this is not used internally at all we should think about removing it but I guess since it
is not too complex we should just or fix it for bwcompat reasons. For released versions we
should really fix it since folks might use it though. For trunk we could just drop it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message