lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2651) Add support for MMapDirectory's unmap in Apache Harmony
Date Sat, 18 Sep 2010 15:03:33 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12911031#action_12911031
] 

Robert Muir commented on LUCENE-2651:
-------------------------------------

I tested the patch, i don't think we should add this yet.

at a basic level, it works. for example TestIndexFileDeleter.testDeleteLeftoverFiles will
pass, where it fails without it.
but other tests will fail, such as TestIndexReaderReopen.

its worth mentioning that mmapdirectory didnt even work at all with 5.0M14, and only started
working with 5.0M15 (released a few days ago).
before the latest release it just wrote corrupted indexes.

so it would be better for now to not supply a cleaner for harmony, and let it default to SimpleFSDirectory
always.


> Add support for MMapDirectory's unmap in Apache Harmony
> -------------------------------------------------------
>
>                 Key: LUCENE-2651
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2651
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2651.patch, LUCENE-2651.patch, LUCENE-2651.patch
>
>
> The setUseUnmap does not work on Apache Harmony, this patch adds support for it. It also
fixes a small problem, that unmapping a clone may cause a sigsegv.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message