lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <>
Subject [jira] Created: (LUCENE-2656) If tests fail, don't report about unclosed resources
Date Mon, 20 Sep 2010 11:36:33 GMT
If tests fail, don't report about unclosed resources

                 Key: LUCENE-2656
             Project: Lucene - Java
          Issue Type: Test
          Components: Tests
    Affects Versions: 3.1, 4.0
            Reporter: Robert Muir
             Fix For: 3.1, 4.0
         Attachments: LUCENE-2656.patch

LuceneTestCase ensures in afterClass() if you closed all your directories, which in turn will
check if you have closed any open files.

This is good, as a test will fail if we have resource leaks.

But if a test truly fails, this is just confusing, because its usually not going to make it
to the part of its code where it would call .close()

So, if any tests fail, I think we should omit this check in afterClass()

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message