lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <>
Subject [jira] Commented: (LUCENE-2611) IntelliJ IDEA setup
Date Tue, 07 Sep 2010 01:23:33 GMT


Robert Muir commented on LUCENE-2611:

bq. AbstractClusteringTest is made abstract, to stop IntelliJ from failing because it has
no test methods.

We should fix this. I think we should also fix the name (*TestBase or similar) for ant. 

bq. TEMP_DIR.mkdirs() is added to setUp() in LuceneTestCase and LuceneTestCaseJ4, so that
various tests don't fail because the parent temporary directory doesn't exist.

I don't think this should occur in setUp(). Ant makes this up front per-jvm, but for IDE's
we should do it in a static { } block, then its consistent with ant.

bq. It's important to isolate the temporary directory used by 3.X branch tests from that used
by trunk, because otherwise 3.X branch tests will fail with unknown index version errors.
(The Sun Oracle JDK's implementation of File.mkdirs() first checks for the existence of the
directory before creating its parent directories, so I don't think this will slow Ant testing
down much.)

I completely agree, but I don't think we should do it in setUp to address it. Currently there
# Lucene Tests that use newDirectory(): these get a TEMP_DIR + random subdir
# Solr tests: these get a TEMP_DIR + random subdir
# Lucene Tests that don't use newDirectory, but use a hardcoded TEMP_DIR + path. we should
fix these to use a random subdir.

The issue with #3 being, that if you aren't using ANT, the TEMP_DIR defaults to your OS system
temp directory, and if you have different checkouts of lucene they will share it... so we
should fix these tests... they shouldnt be hard to find.

> IntelliJ IDEA setup
> -------------------
>                 Key: LUCENE-2611
>                 URL:
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: Build
>    Affects Versions: 3.1, 4.0
>            Reporter: Steven Rowe
>            Priority: Minor
>             Fix For: 3.1, 4.0
>         Attachments: LUCENE-2611-branch-3x.patch, LUCENE-2611-branch-3x.patch, LUCENE-2611-branch-3x.patch,
LUCENE-2611.patch, LUCENE-2611.patch, LUCENE-2611.patch, LUCENE-2611.patch, LUCENE-2611.patch,
LUCENE-2611_test.patch, LUCENE-2611_test.patch, LUCENE-2611_test.patch, LUCENE-2611_test.patch,
> Setting up Lucene/Solr in IntelliJ IDEA can be time-consuming.
> The attached patch adds a new top level directory {{dev-tools/}} with sub-dir {{idea/}}
containing basic setup files for trunk, as well as a top-level ant target named "idea" that
copies these files into the proper locations.  This arrangement avoids the messiness attendant
to in-place project configuration files directly checked into source control.
> The IDEA configuration includes modules for Lucene and Solr, each Lucene and Solr contrib,
and each analysis module.  A JUnit test run per module is included.
> Once {{ant idea}} has been run, the only configuration that must be performed manually
is configuring the project-level JDK.
> If this patch is committed, Subversion svn:ignore properties should be added/modified
to ignore the destination module files (*.iml) in each module's directory.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message