lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <>
Subject [jira] Commented: (LUCENE-2662) BytesHash
Date Wed, 22 Sep 2010 15:53:32 GMT


Robert Muir commented on LUCENE-2662:

Jason: what I am saying is if i look at the method in your patch:

public T add(BytesRef bytes)

the first thing it does is compute the hash, but this is already computed in the analysis

why not have
public T add(BytesRef bytes, int hashCode)

and also:
public T add(BytesRef bytes) {
  return add(bytes, bytes.hashCode());

then we can avoid computing this twice, and keep the optimization in UnicodeUtil

> BytesHash
> ---------
>                 Key: LUCENE-2662
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: Realtime Branch
>            Reporter: Jason Rutherglen
>            Priority: Minor
>             Fix For: Realtime Branch
>         Attachments: LUCENE-2662.patch
> This issue will have the BytesHash separated out from LUCENE-2186

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message