lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (SOLR-2134) Trie* fields should support sortMissingLast=true, and deprecate Sortable* Field Types
Date Tue, 28 Sep 2010 16:32:33 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915816#action_12915816
] 

Uwe Schindler edited comment on SOLR-2134 at 9/28/10 12:30 PM:
---------------------------------------------------------------

I don't expect adding/subtracting anything to infinity changes its value (at least the IEEE-754
specs say it should not change anything). I would keep this as it is, I wanted to just note,
that the undefined value may collide with a real value. So if you have e.g. Integer.MAX_VALUE
in the slot but your missingValue is also Integer.MAX_VALUE, then sorting at this place is
strange. But this affects all data types and was like that since ever?

The problem is NaN (as it is with function queries where the score is NaN):
NaN order is not undefined but behaves different than you expect (it means if you ever compare
NaN with anything using <, >, == it will return always false). This will mix up the
sorting, so defining it as missingValue is maybe a good idea. But as said before, you cannot
compare with NaN, it will always return false, so use Double.isNan(cached.values[doc]) :-)

      was (Author: thetaphi):
    I don't expect adding/subtracting anything to infinity changes its value (at least the
IEEE-754 specs say it should not change anything). NaN order is not undefined but behaves
different than you expect (it means if you ever compare NaN with anything using <, >,
== it will return always false). This will mix up the sorting, so defining it as missingValue
is maybe a good idea. But as said before, you cannot compare with NaN, it will always return
false, so use Double.isNan(cached.values[doc]) :-)
  
> Trie* fields should support sortMissingLast=true, and deprecate Sortable* Field Types
> -------------------------------------------------------------------------------------
>
>                 Key: SOLR-2134
>                 URL: https://issues.apache.org/jira/browse/SOLR-2134
>             Project: Solr
>          Issue Type: Improvement
>          Components: Schema and Analysis
>            Reporter: Ryan McKinley
>         Attachments: SOLR-2134-SortMissingLast.patch, SOLR-2134-SortMissingLast.patch,
SOLR-2134-SortMissingLast.patch, SOLR-2134-SortMissingLast.patch
>
>
> With the changes in LUCENE-2649, the FieldCache also returns if the bit is valid or not.
 This is enough to support sortMissingLast=true with Trie* fields.  Then we can get rid of
the Sortable* fields

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message