lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2652) Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM
Date Sun, 19 Sep 2010 15:15:32 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912237#action_12912237
] 

Robert Muir commented on LUCENE-2652:
-------------------------------------

{quote}
I added support for tests.locale=all && tests.codec=all while still utilizing the
TestRunners we used before. With this patch we preserve all functionality we had before -
being able to run with all locale / codec types for those tests which have been marked with
the corresponding runners. Should we commit that until we change to a single runner?
{quote}

Not sure, i think its a little confusing, because this 'all' only affects tests that use the
runner.

I still think we should remove these runners completely. there is other ways to test all locales/codecs:
for example by doing ant test -Dtestcase=foo -Dtests.iter=1000, as it should randomly hit
them all anyway, same with codecs.

and this works for all test cases, not just those annotated with the runners.

> Rethink LocalizedTestCaseRunner with JUnit 4 - Clover OOM
> ---------------------------------------------------------
>
>                 Key: LUCENE-2652
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2652
>             Project: Lucene - Java
>          Issue Type: Test
>          Components: Tests
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2652.patch, LUCENE-2652.patch, LUCENE-2652.patch
>
>
> As a spinn off from this [conversation|http://www.lucidimagination.com/search/document/ae20885bf5baedc5/build_failed_in_hudson_lucene_3_x_116#7ed351341152ee2d]
we should rethink the way how we execute testcases with different locals since glover reports
appears to throw OOM errors b/c Junit treats each local as a single test case run.
> Here are some options:
> * select the local at random only run the test with a single local
> * set the local via system property -Dtest.locale=en.EN
> * run with the default locale only -Dtest.skiplocale=true
> * one from the above but only if instrumented with clover (let common tests run all the
locale)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message