lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs
Date Fri, 17 Sep 2010 15:20:37 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910625#action_12910625
] 

Shai Erera commented on LUCENE-2649:
------------------------------------

bq. Are there any advantages to using payloads over CSF for fieldcache population?

Well .. payloads already exist (in my code :)), while CSF is "just around the corner" for
a long time. While the two ultimately achieve the same goal, CSF is more generic than just
payloads, and if we'd want to take advantage of it w/ FieldCache, I assume we'll need to make
more changes to FieldCache, because w/ CSF, people can store arbitrary byte[] and request
to cache them. So sorting data is a subset of CSF indeed, but I think the road to CSF + CSF-FieldCache
integration is long. But perhaps I'm not up-to-date and there is progress / someone actually
working on CSF?

Anyway, opening up FC to read from payloads seems to me a much easier solution, because besides
reading the stuff from the payload, the rest of the classes continue to work the same (TopFieldCollector,
Comparators etc.).

Maybe a slight change to SortField will be required as well though, not sure yet.

> FieldCache should include a BitSet for matching docs
> ----------------------------------------------------
>
>                 Key: LUCENE-2649
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2649
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>             Fix For: 4.0
>
>         Attachments: LUCENE-2649-FieldCacheWithBitSet.patch, LUCENE-2649-FieldCacheWithBitSet.patch
>
>
> The FieldCache returns an array representing the values for each doc.  However there
is no way to know if the doc actually has a value.
> This should be changed to return an object representing the values *and* a BitSet for
all valid docs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message