lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <>
Subject [jira] Updated: (LUCENE-2650) improve windows defaults in FSDirectory
Date Fri, 17 Sep 2010 17:56:33 GMT


Robert Muir updated LUCENE-2650:

    Attachment: LUCENE-2650.patch

Here's the patch:
* sets the defaults as described in the issue
* turns on unmap by default if its possible
* when unmapping inputs, we should be careful to never allow the region to be accessed.
 so in close(), we ensure that clones, too set their buffer to null.
 and in clone() we add a friendlier exception rather than NPE.

> improve windows defaults in FSDirectory
> ---------------------------------------
>                 Key: LUCENE-2650
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Store
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>             Fix For: 4.0
>         Attachments: LUCENE-2650.patch
> Currently windows defaults to SimpleFSDirectory, but this is a problem due to the synchronization.
> I have been benchmarking queries *sequentially* and was pretty surprised at how much
> MMapDirectory is, for example for cases that do many seeks.
> I think we should change the defaults for windows as such:
> if (WINDOWS and UNMAP_SUPPORTED and 64-bit)
>   use MMapDirectory
> else
>   use SimpleFSDirectory 
> I think we should just consider doing this for 4.0 only and see how it goes.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message