lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan McKinley (JIRA)" <>
Subject [jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs
Date Wed, 22 Sep 2010 17:29:35 GMT


Ryan McKinley commented on LUCENE-2649:

bq. Hmm... I'd rather make an exception to 3.x, ie, allow the addition of this method to the
interface, than confuse the 4.x API, going forward, with 2 classes?

That is OK with me.  Would be cleaner and simpler.  (though semantically it does not make
sense to me -- why ask the parser what to cache?)

bq. >>    This does cache a MatchAllBits even when 'cacheValidBits' is false, since
that is small (a small class with one int)
bq. Hmm... but if I pass false here, it shouldn't spend any time allocating the bit set, building
it, checking the bit set for "all bits set", etc.?

Well it does not try *hard*, only if numDocs==maxDocs, it does not look at anything.  If the
cost of caching new MatchAllBits( maxDocs ) isn't worth occasional win by knowing all the
values are valid, then I will remove it.

bq. So how about we add a getBits(field)

Interesting... i'll mess for a bit and let you know what I think :)

rather then throwing an exception, that might be a flag, since I could imagin many thigns
would use the Bits if they exist and do something else if they dont

> FieldCache should include a BitSet for matching docs
> ----------------------------------------------------
>                 Key: LUCENE-2649
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>             Fix For: 4.0
>         Attachments: LUCENE-2649-FieldCacheWithBitSet.patch, LUCENE-2649-FieldCacheWithBitSet.patch,
LUCENE-2649-FieldCacheWithBitSet.patch, LUCENE-2649-FieldCacheWithBitSet.patch, LUCENE-2649-FieldCacheWithBitSet.patch
> The FieldCache returns an array representing the values for each doc.  However there
is no way to know if the doc actually has a value.
> This should be changed to return an object representing the values *and* a BitSet for
all valid docs.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message