lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan McKinley (JIRA)" <>
Subject [jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs
Date Thu, 23 Sep 2010 16:44:37 GMT


Ryan McKinley commented on LUCENE-2649:

I think getCachePopulator() should be under EntryConfig - that way people can provide their
own (and extend ByteValues to include more info)

So you think it is better for *each* call to define how the cache works rather then having
that as an attribute of the FieldCache (that could be extended).  The on thing that concerns
me is that that forces all users of the FieldCache to be in sync.

In this proposal, you could set the CachePopulator on the FieldCache. 

Otherwise, we'll forever be locked into a lowest common denominator of only adding info that
everyone can agree on.

This is why I just added the 'createXxxxValues' functions on CachePopulator -- a subclass
could add other values.


It looks like the basic difference between what we are thinking is that the Populator is attached
to the FieldCache rather then each call to the FieldCache.  From my point of view, this would
make it easier for system with a schema (like solr) have consistent results across all calls,
rather then making each request to the FieldCache need to know about the schema -> parsers
-> populator

but I can always be convinced ;)

> FieldCache should include a BitSet for matching docs
> ----------------------------------------------------
>                 Key: LUCENE-2649
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>             Fix For: 4.0
>         Attachments: LUCENE-2649-FieldCacheWithBitSet.patch, LUCENE-2649-FieldCacheWithBitSet.patch,
LUCENE-2649-FieldCacheWithBitSet.patch, LUCENE-2649-FieldCacheWithBitSet.patch, LUCENE-2649-FieldCacheWithBitSet.patch
> The FieldCache returns an array representing the values for each doc.  However there
is no way to know if the doc actually has a value.
> This should be changed to return an object representing the values *and* a BitSet for
all valid docs.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message