lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] Commented: (LUCENE-2662) BytesHash
Date Tue, 28 Sep 2010 12:34:34 GMT


Michael McCandless commented on LUCENE-2662:

I don't like addByBytesStart I would like to keep offset since it really is an offset into
the pool. addByPoolOffset?
The names ord and bytesStart are a good compromise  lets shoot for that.


bq. we could factor out a super class from ParallelPostingArray which only has the textStart
int array, the grow and copy method and let ParallelPostingArray subclass it.

This seems good?  So, this would be the "store" that BRH manages... and by subclassing it
you can have other parallel arrays storing anything, indexed by ord.

bq. I did exactly that in the not yet uploaded patch. But I figured that it would maybe make
more sense to use that AtomicInt in the allocator as well as in THPF or is that what you mean?

I think we should use it everywhere to track bytes used ;)

bq. man, I am sorry - I thought I will use this in LUCENE-2186 in a single threaded env but
if so I should change it there if needed. I was one step ahead though.
I will change and maybe have a second one if needed. Agree?

Ahh that's right I forgot the whole driver for this refactoring heh ;)  Yeah I think leave
it sync'd for now and we can test if this hurts perf in LUCENE-2186?  "Supposedly" uncontended
locks are low-cost (but I'm not sure...).

> BytesHash
> ---------
>                 Key: LUCENE-2662
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: Realtime Branch, 4.0
>            Reporter: Jason Rutherglen
>            Assignee: Simon Willnauer
>            Priority: Minor
>             Fix For: Realtime Branch, 4.0
>         Attachments: LUCENE-2662.patch, LUCENE-2662.patch, LUCENE-2662.patch, LUCENE-2662.patch
> This issue will have the BytesHash separated out from LUCENE-2186

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message