lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan McKinley (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2649) FieldCache should include a BitSet for matching docs
Date Fri, 17 Sep 2010 18:03:33 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910700#action_12910700
] 

Ryan McKinley commented on LUCENE-2649:
---------------------------------------

Are people generally ok with the idea of global on/off?  I think that is a reasonable approach...
I agree that we should avoid static fields to control behavior.  But do we avoid it at the
cost of not allowing the option, or waiting till we rework FieldCache?

If the consensus is that FieldCache needs to be reworked *before* somethign like this could
be added, that's fine... i'll move on to other things.  Any relatively easy suggestions for
how to enable the option without a global static?  (Note that FieldCache is already a global
static -- at leaset FieldCache.DEFAULT is referenced a lot)

Perhaps this could/should live in /trunk until a cleaner solution is viable?





> FieldCache should include a BitSet for matching docs
> ----------------------------------------------------
>
>                 Key: LUCENE-2649
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2649
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>             Fix For: 4.0
>
>         Attachments: LUCENE-2649-FieldCacheWithBitSet.patch, LUCENE-2649-FieldCacheWithBitSet.patch,
LUCENE-2649-FieldCacheWithBitSet.patch
>
>
> The FieldCache returns an array representing the values for each doc.  However there
is no way to know if the doc actually has a value.
> This should be changed to return an object representing the values *and* a BitSet for
all valid docs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message