Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Message-ID: <585828.163911280949198617.JavaMail.jira@thor>
Date: Wed, 4 Aug 2010 15:13:18 -0400 (EDT)
From: "David Smiley (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Subject: [jira] Created: (SOLR-2027) SolrJ FacetField should never return
 null from getValues()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

SolrJ FacetField should never return null from getValues()
----------------------------------------------------------

                 Key: SOLR-2027
                 URL: https://issues.apache.org/jira/browse/SOLR-2027
             Project: Solr
          Issue Type: Improvement
          Components: clients - java
    Affects Versions: 1.4.1
            Reporter: David Smiley
            Priority: Minor


In some circumstances, FacetField.getValues() will return null.  I'd like for my iteration code to simply be:
{code:java}
for (c : ff.getValues() { 
  // ...
}
{code}
However this will throw an NPE if I don't wrap this in either a null check or this check: ff.getValueCount() > 0

I propose that getValues() return a Collections.EMPTY_LIST if the internal value is null.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org