From dev-return-54996-apmail-lucene-dev-archive=lucene.apache.org@lucene.apache.org Wed Aug 25 09:43:06 2010 Return-Path: Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: (qmail 93633 invoked from network); 25 Aug 2010 09:43:05 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 25 Aug 2010 09:43:05 -0000 Received: (qmail 33500 invoked by uid 500); 25 Aug 2010 09:43:05 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 32982 invoked by uid 500); 25 Aug 2010 09:43:01 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 32975 invoked by uid 99); 25 Aug 2010 09:43:01 -0000 Received: from Unknown (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Aug 2010 09:43:01 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Aug 2010 09:42:43 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o7P9gMWo004107 for ; Wed, 25 Aug 2010 09:42:22 GMT Message-ID: <29482888.555201282729342091.JavaMail.jira@thor> Date: Wed, 25 Aug 2010 05:42:22 -0400 (EDT) From: =?utf-8?Q?Jan_H=C3=B8ydahl_=28JIRA=29?= To: dev@lucene.apache.org Subject: [jira] Commented: (SOLR-2079) Expose HttpServletRequest object from SolrQueryRequest object In-Reply-To: <29982466.508251282573638110.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/SOLR-2079?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12902= 359#action_12902359 ]=20 Jan H=C3=B8ydahl commented on SOLR-2079: ----------------------------------- I have been using SolrParams to convey metadata from frontends to middlewar= e layer, and I think it has worked really well. In addition, you get it inc= luded in the query logs! As for load balancers, most have an option to convey the client's IP in the= "X-Forwarded-For" header. What if the dispatchFilter adds all HTTP headers to the SolrQueryRequest co= ntext. Then we could map explicitly in requestHandler config how to use the= m: {code:xml} $HTTP_HEADERS(X-Forwarded-For, Remote-Add= ress) {code} This would mean that if HTTP header X-Forwarded-For exists in the context, = it will be mapped to param _http_remote-ip, if not, it will use Remote-Addr= ess. In this way each application can choose whether to "pollute" the SolrP= arams with headers or not, choose naming as well as whether it should be in= variant or default. > Expose HttpServletRequest object from SolrQueryRequest object > ------------------------------------------------------------- > > Key: SOLR-2079 > URL: https://issues.apache.org/jira/browse/SOLR-2079 > Project: Solr > Issue Type: Improvement > Components: Response Writers, search > Reporter: Chris A. Mattmann > Fix For: 3.1 > > Attachments: SOLR-2079.Quach.Mattmann.082310.patch.txt > > > This patch adds the HttpServletRequest object to the SolrQueryRequest obj= ect. The HttpServletRequest object is needed to obtain the client's IP addr= ess for geotargetting, and is part of the patches from W. Quach and C. Matt= mann. --=20 This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org