lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <>
Subject [jira] Commented: (SOLR-2051) analysis.jsp is incorrect for protWords etc
Date Mon, 16 Aug 2010 21:56:31 GMT


Robert Muir commented on SOLR-2051:

Insert a tap after each filter? Yeah, might be safer by more closely emulating how the analysis
actually works.
For example, if someone develops some whacky filters that rely on thread locals to pass info
or something.

Since it looks like you've fixed it already, I'd just commit that though.

Well, Uwe suggested CachingTokenFilter as one idea, we could keep the same overall flow. 

A 'printing tap' after each filter seems even better though... lemme try it and worse case
we have this as the fix for now.

> analysis.jsp is incorrect for protWords etc
> -------------------------------------------
>                 Key: SOLR-2051
>                 URL:
>             Project: Solr
>          Issue Type: Bug
>          Components: web gui
>    Affects Versions: 3.1, 4.0
>            Reporter: Robert Muir
>         Attachments: SOLR-2051.patch, SOLR-2051.patch
> Analysis.jsp gives the incorrect results if you use "protwords.txt" or "stemdict.txt"
or the like.
> This is because this is now implemented with KeywordAttribute (so you can easily override
any stemmer etc).
> For example, if your schema had "foobars" in protwords.txt, analysis.jsp would show it
being stemmed to "foobar", even though this doesnt actually happen.
> The problem is that this jsp is downconverting the entire tokenstream to Token in between
processing, so it silently discards KeywordAttribute and you get the wrong result.
> Note: this issue isnt about *displaying* other attributes such as KeywordAttribute (which
would be a new feature). Its about not throwing them away so that the analysis actually represents
what happens.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message