lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2606) optimize contrib/regex for flex
Date Wed, 18 Aug 2010 20:55:17 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900028#action_12900028
] 

Robert Muir commented on LUCENE-2606:
-------------------------------------

bq. Looks good! The thing was broken in 3.x and 3.0, too as it was not threadsafe, if the
same capabilities object was used in multiple threads.

True, I think we have the opportunity to fix it in 4.x since we have to break the interface
anyway.

Should we do anything about 3.x? It seems good to fix bugs, but it would be frustrating (if
someone has a custom RegexCapabilities) to break the API in 3.x, then in 4.x again!


> optimize contrib/regex for flex
> -------------------------------
>
>                 Key: LUCENE-2606
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2606
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-2606.patch, LUCENE-2606.patch
>
>
> * changes RegexCapabilities match(String) to match(BytesRef)
> * the jakarta and jdk impls uses CharacterIterator/CharSequence matching against the
utf16result instead.
> * i also reuse the matcher for jdk, i don't see why we didnt do this before but it makes
sense esp since we reuse the CSQ

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message