lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrzej Bialecki (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-1316) Create autosuggest component
Date Thu, 19 Aug 2010 13:20:32 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900275#action_12900275
] 

Andrzej Bialecki  commented on SOLR-1316:
-----------------------------------------

Robert,
bq. But i have trouble understanding what the point of all the complexity in this method is...
if its just as its documented, it seems it could be much simpler: (eg b-a). So I feel like
I am missing something.

I don't get it either... it's a borrowed code after all ;) Anyway, I replaced this method
with the following:

{code}
  private static int compareCharsAlphabetically(char cCompare2, char cRef) {
    return Character.toLowerCase(cCompare2) - Character.toLowerCase(cRef);
  }
{code}

and all tests pass, including those that test for correctness of returned suggestions and
consistency between Jaspell and TST. I also ran testBenchmark() and differences in timings
are negligible.

Grant,
bq. I think we should at least open an issue for it and link to this one when this one gets
committed, as it takes a while to build.
Yes, I'll open an issue when this gets committed.

If there are no further objections I'd like to commit this.


> Create autosuggest component
> ----------------------------
>
>                 Key: SOLR-1316
>                 URL: https://issues.apache.org/jira/browse/SOLR-1316
>             Project: Solr
>          Issue Type: New Feature
>          Components: search
>    Affects Versions: 1.4
>            Reporter: Jason Rutherglen
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: Next
>
>         Attachments: SOLR-1316.patch, SOLR-1316.patch, SOLR-1316.patch, SOLR-1316.patch,
SOLR-1316.patch, SOLR-1316.patch, SOLR-1316.patch, SOLR-1316.patch, suggest.patch, suggest.patch,
suggest.patch, TST.zip
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> Autosuggest is a common search function that can be integrated
> into Solr as a SearchComponent. Our first implementation will
> use the TernaryTree found in Lucene contrib. 
> * Enable creation of the dictionary from the index or via Solr's
> RPC mechanism
> * What types of parameters and settings are desirable?
> * Hopefully in the future we can include user click through
> rates to boost those terms/phrases higher

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message