lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-1665) Add &debugTimings param so that timings for components can be retrieved without having to do explains(), as in &debugQuery
Date Thu, 26 Aug 2010 17:15:53 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902936#action_12902936
] 

Yonik Seeley commented on SOLR-1665:
------------------------------------

This seems a bit over-engineered?
What's the point of having a "Set<String> debugInterests" and doing a lookup on that
rather than just doing a lookup on the params?

And changing addDebugInfo(String interest, String name, Object val )
so that it checks debugInterest to see if the info should be added?  One of the main points
is to not generate debug info if it's not asked for.

I'd almost prefer taking a step back and implementing only what the original issue talked
about:  add a debugTimings param that did timings only - that's the special case and the only
one we've identified that makes sense.


> Add &debugTimings param so that timings for components can be retrieved without having
to do explains(), as in &debugQuery
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-1665
>                 URL: https://issues.apache.org/jira/browse/SOLR-1665
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>             Fix For: Next
>
>         Attachments: SOLR-1665.patch
>
>
> As the title says, it would be great if we could just get back component timings w/o
having to do the full boat of explains and other stuff.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message