lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Drew Farris (JIRA)" <>
Subject [jira] Updated: (SOLR-2057) DataImportHandler never calls UpdateRequestProcessor.finish()
Date Thu, 19 Aug 2010 02:24:16 GMT


Drew Farris updated SOLR-2057:

    Attachment: SOLR-2057.patch

This patch against branch_3x adds a finish() method to SolrWriter which in turn calls UpdateRequestProcessor.finish().

It appears that other classes call finish() regardless of the update's final state, so I added
a call to finish to DocBuilder in what seems like an appropriate location near the end of

Updated unit tests to add a TestUpdateRequestProcessor, and validate that the appropriate
methods are being called in the major cases.

> DataImportHandler never calls UpdateRequestProcessor.finish()
> -------------------------------------------------------------
>                 Key: SOLR-2057
>                 URL:
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.4.1, 3.1, 4.0
>            Reporter: Drew Farris
>            Priority: Minor
>         Attachments: SOLR-2057.patch
> I was experimenting with custom UpdateRequestProcessor implementations and noticed that
the sample LogUpdateProcessorFactory's finish method wasn't being called. I tracked this back
down to the fact that SolrWriter in the data import handler never calls the finish() method
on its UpdateRequestProcessor.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message