lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Grant Ingersoll (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-1665) Add &debugTimings param so that timings for components can be retrieved without having to do explains(), as in &debugQuery
Date Thu, 26 Aug 2010 19:53:57 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903010#action_12903010
] 

Grant Ingersoll commented on SOLR-1665:
---------------------------------------

I was just going to do a enum type, but then figured why not let others extend.  FWIW, we
did identify three cases: timings, results/explains and queries, and that is what I did. 


bq. And changing addDebugInfo(String interest, String name, Object val )
so that it checks debugInterest to see if the info should be added? One of the main points
is to not generate debug info if it's not asked for.

ResponseBuilder.addDebugInfo() w/o the interest being passed in has no context as to whether
it should be called or not.  Moving the if clause to be around the call to addDebugInfo instead
of in it then requires the caller to have knowledge of the debug interests.  That being said,
I suppose if we just do param lookup each time, it's not a big deal.

> Add &debugTimings param so that timings for components can be retrieved without having
to do explains(), as in &debugQuery
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-1665
>                 URL: https://issues.apache.org/jira/browse/SOLR-1665
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>             Fix For: Next
>
>         Attachments: SOLR-1665.patch
>
>
> As the title says, it would be great if we could just get back component timings w/o
having to do the full boat of explains and other stuff.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message