lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] Updated: (LUCENE-2600) don't try to cache a composite reader's MultiBits deletedDocs
Date Sat, 14 Aug 2010 13:34:15 GMT


Michael McCandless updated LUCENE-2600:

    Attachment: LUCENE-2600.patch

Another iteration of the patch.

This one removes IndexReader.isDeleted, in favor of IndexReader.getDeletedDocs.  This then
enabled removing ReadOnlySegment/DirReader classes, which is a nice simplificaton.

I also fixed MultiFields.getDeletedDocs to re-ask the underlying readers for their .getDeletedDocs()
when they previously returned null, to handle the non-readonly composite reader case.

> don't try to cache a composite reader's MultiBits deletedDocs
> -------------------------------------------------------------
>                 Key: LUCENE-2600
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 4.0
>         Attachments: LUCENE-2600.patch, LUCENE-2600.patch
> MultiFields.getDeletedDocs now builds up a MultiBits instance (so that one can check
if a top-level docID is deleted), but it now stuffs it into a private cache on IndexReader.
> This is invalid when the composite reader is read/write, and can result in a MultiReader
falsely claiming a doc was not deleted.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message