Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Message-ID: <8339797.281921278672650061.JavaMail.jira@thor>
Date: Fri, 9 Jul 2010 06:50:50 -0400 (EDT)
From: "Michael McCandless (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Subject: [jira] Commented: (LUCENE-2530) rename docsEnum.getBulkResult() to
 make its role clearer
In-Reply-To: <24322647.281671278671455993.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LUCENE-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886676#action_12886676 ] 

Michael McCandless commented on LUCENE-2530:
--------------------------------------------

I agree, we should rename it, to make it clear it's mandatory that you call it.  I like prepareBulkResult.

> rename docsEnum.getBulkResult() to make its role clearer
> --------------------------------------------------------
>
>                 Key: LUCENE-2530
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2530
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>    Affects Versions: 4.0
>            Reporter: Andi Vajda
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 4.0
>
>
> Before docsEnum.read() can be called a BulkResult instance must be allocated for it (it == the default implementation of that method).
> This is done by calling docsEnum.getBulkResult(). Failure to call this method before read() is called results in a NullPointerException.
> It is somewhat counterintuitive to "get" the results of an operation before calling said operation.
> Maybe this method should be renamed to something more definite-sounding like obtainBulkResult() or prepareBulkResult() ?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org