lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] Updated: (SOLR-1981) solr.xml should fail to load if multiple cores with the same name
Date Fri, 09 Jul 2010 22:30:50 GMT

     [ https://issues.apache.org/jira/browse/SOLR-1981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Hoss Man updated SOLR-1981:
---------------------------

    Attachment: SOLR-1981.patch

aparently i never actually tested that patch when i wrote it -- i just discovered that it
breaks *everything* because i removed the 'name=""' that happens for hte default core.

new patch adds that back, along with a comment about why it's there, and includes a new check
to ensure that name is always specified (no NPE if it's missing)

> solr.xml should fail to load if multiple cores with the same name
> -----------------------------------------------------------------
>
>                 Key: SOLR-1981
>                 URL: https://issues.apache.org/jira/browse/SOLR-1981
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>         Attachments: SOLR-1981.patch, SOLR-1981.patch
>
>
> As noted in email a while back...
> http://search.lucidimagination.com/search/document/674bf5dfbbb349bc/multiple_cores_w_same_name_in_solr_xml
> {quote}
> but there is currently no assertion that every core have a name, or that the
> names be unique before the SolrCore is constructed ... it's not until the core is registered
that an error will be
> generated if the core name is null, or that the previous core with an identicle name
will be close()ed.
> {quote}
> I think we should fail fast if solr.xml specifies the same name more then once

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message