Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Received-SPF: pass (nike.apache.org: domain of erik.hatcher@gmail.com
 designates 209.85.212.48 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:from:to:in-reply-to:content-type
         :content-transfer-encoding:mime-version:subject:date:references
         :x-mailer;
        b=qhHTvLs/Q1Gayzl764Z7REoq1HHyGsfMywJ+IydZgU1D9OQ363QQdg/fpgcV/GGGnr
         lJl1EIRagUdbkF2oregLeNgPghqHavmtt+lGMomYPL81S2fv2QVJZzKpD9mXRN6C2Zc7
         HW7Ul5EtCCW0ky++8mMWgpns50Yw59UfPocj4=
Message-Id: <6DB4D079-D2A0-4261-9C30-F811765169D3@gmail.com>
From: Erik Hatcher <erik.hatcher@gmail.com>
To: dev@lucene.apache.org
In-Reply-To: <alpine.DEB.1.10.1006161559320.392@radix.cryptio.net>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v936)
Subject: Re: [VOTE] Release Solr 1.4.1
Date: Thu, 17 Jun 2010 06:59:02 -0400
References: <4C17A246.4000709@gmail.com>
 <alpine.DEB.1.10.1006161559320.392@radix.cryptio.net>


On Jun 16, 2010, at 7:00 PM, Chris Hostetter wrote:
> --
>
> I'm seeing multiple velocity contrib jars w/odd file names...
>
> $ ls contrib/velocity/src/main/solr/lib/*solr*
> contrib/velocity/src/main/solr/lib/apache-solr-velocity-1.4.1-dev.jar
> contrib/velocity/src/main/solr/lib/apache-solr-velocity-1.4.1.jar
> contrib/velocity/src/main/solr/lib/apache-solr-velocity-1.4.2-dev.jar
> contrib/velocity/src/main/solr/lib/apache-solr-velocity-X.Y.M.jar
>
> ...this is probably a show stopper that will require a new RC.
>
> having multiple versions of the jar could easily break things with
> class incompatibilities depending on what version they get loaded in
> by the classloader.

A change was made on trunk to contrib/velocity/build.xml to clean up  
these old JARs:

   <target name="clean">
   	<delete failonerror="false" dir="target"/>
   	<delete>
   	  <fileset dir="src/main/solr/lib" includes="apache-solr-velocity- 
*.jar"/>
   	</delete>
   </target>

It's not on branch-1.4 though.  Should it be?  But at the very least,  
indeed those apache-solr-velocity-*.jar should be removed prior to a  
build.

> (FWIW: all of the "solr" jars are all suppose to be in "dist" ... but
> it looks like that dir is where the apache-solr-velocity jar was in
> 1.4.0 as well so probably not something we should change in this
> release)

Noted - I'll fix this as VrW is moved to core.

	Erik


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org