Return-Path: Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: (qmail 35889 invoked from network); 3 Jun 2010 13:08:32 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 3 Jun 2010 13:08:32 -0000 Received: (qmail 13461 invoked by uid 500); 3 Jun 2010 13:08:31 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 13369 invoked by uid 500); 3 Jun 2010 13:08:30 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 13362 invoked by uid 99); 3 Jun 2010 13:08:30 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Jun 2010 13:08:30 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Jun 2010 13:08:28 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o53D86so028847 for ; Thu, 3 Jun 2010 13:08:06 GMT Message-ID: <32397065.158001275570486497.JavaMail.jira@thor> Date: Thu, 3 Jun 2010 09:08:06 -0400 (EDT) From: "Yonik Seeley (JIRA)" To: dev@lucene.apache.org Subject: [jira] Commented: (SOLR-1938) make ElisionFilterFactory user-friendly In-Reply-To: <11821784.151001275536997077.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/SOLR-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875089#action_12875089 ] Yonik Seeley commented on SOLR-1938: ------------------------------------ Yep, makes sense. > make ElisionFilterFactory user-friendly > --------------------------------------- > > Key: SOLR-1938 > URL: https://issues.apache.org/jira/browse/SOLR-1938 > Project: Solr > Issue Type: Improvement > Components: Schema and Analysis > Reporter: Robert Muir > Assignee: Robert Muir > Fix For: 3.1, 4.0 > > Attachments: SOLR-1938.patch > > > The ElisionFilterFactory is useful for removing french articles from words (e.g. l'avion -> avion, see its tests). > But the factory itself isnt very friendly, you need to provide an actual text file listing these, which is sorta overkill > Such a text file would look like: > {noformat} > # below are my articles > l > m > t > ... > {noformat} > I propose instead of throwing a RuntimeException if you dont provide the articles param, to just use the default set > already in ElisionFilter: (l, m, t, qu, n, s, j) > It wont backwards break anyone as if they weren't providing it, they were getting RuntimeException before. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org