Return-Path: Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: (qmail 49092 invoked from network); 24 Jun 2010 20:39:16 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 24 Jun 2010 20:39:16 -0000 Received: (qmail 32602 invoked by uid 500); 24 Jun 2010 20:39:15 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 32557 invoked by uid 500); 24 Jun 2010 20:39:14 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 32486 invoked by uid 99); 24 Jun 2010 20:39:14 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Jun 2010 20:39:14 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Jun 2010 20:39:12 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o5OKcpNh019556 for ; Thu, 24 Jun 2010 20:38:51 GMT Message-ID: <15791167.46511277411931114.JavaMail.jira@thor> Date: Thu, 24 Jun 2010 16:38:51 -0400 (EDT) From: "Robert Muir (JIRA)" To: dev@lucene.apache.org Subject: [jira] Commented: (LUCENE-2514) Change Term to use bytes In-Reply-To: <5843276.41171277397049817.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LUCENE-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882318#action_12882318 ] Robert Muir commented on LUCENE-2514: ------------------------------------- Uwe thanks, I would prefer if you did MTQ too. I agree it should completely use BytesRef... i think it should also not create new Terms even until rewriting. For example, currently the priority queue in TopTerms does BytesRef -> String conversion and creates a new Term for each add, but this might be entirely useless as it could fall off the pq, so i think its ScoreTerm or whatever should not hold term at all but just bytesref. > Change Term to use bytes > ------------------------ > > Key: LUCENE-2514 > URL: https://issues.apache.org/jira/browse/LUCENE-2514 > Project: Lucene - Java > Issue Type: Task > Components: Search > Affects Versions: 4.0 > Reporter: Robert Muir > Attachments: LUCENE-2514-surrogates-dance.patch, LUCENE-2514.patch, LUCENE-2514.patch, LUCENE-2514.patch, LUCENE-2514.patch > > > in LUCENE-2426, the sort order was changed to codepoint order. > unfortunately, Term is still using string internally, and more importantly its compareTo() uses the wrong order [utf-16]. > So MultiTermQuery, etc (especially its priority queues) are currently wrong. > By changing Term to use bytes, we can also support terms encoded as bytes such as numerics, instead of using > strange string encodings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org