lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Hostetter <>
Subject Re: [VOTE] Release Solr 1.4.1
Date Wed, 16 Jun 2010 23:00:09 GMT
On Tue, 15 Jun 2010, Mark Miller wrote:

: Date: Tue, 15 Jun 2010 11:54:46 -0400
: From: Mark Miller <>
: Reply-To:
: To:
: Subject: [VOTE] Release Solr 1.4.1
: Please vote on releasing the Solr 1.4.1 artifacts located at
: http://

Source wise things look good -- but I think we're going to need another RC
because of some cruft i'm seeing in the release. full details below...


### Review of these artifacts...

md5sum apache-solr-1.4.1.tgz
915febc17bd40eb7db2f8be318fd439d  apache-solr-1.4.1.tgz

### Things I looked at

 - recursive diff of tgz and zip artifacts to make sure they match
   - ignoring line endings for obvious reasons
 - basic usage of example via the tutorial
 - recursive diff of 1.4.0 with 1.4.1 
   - verify that file lists are the same, except where expected
   - detailed reviewed all src diffs 

### Notes

all src diffs corrispond with my expecations based on CHANGES.txt


the javadocs seem to have been built with javadoc 1.6 (not 1.5)
... this seems to have changed the link style somewhat significantly.
doesn't seem like it's a problem, but it was a little hard to review
for changes.  If we do another RC it may be worthwhile to ensure
Javadoc 1.5 is used for consistency with Solr 1.4.0

(if JAVA_HOME is set to a 1.5 java install during build this shouldn't
be a problem) 


there is an odd looking "bin" directory at the top level of the
release containing all the test files and the *.class files.  not sure
where that came from (artifact of miller's IDE?) ... it's 7MB of cruft.


I'm seeing multiple velocity contrib jars w/odd file names...

$ ls contrib/velocity/src/main/solr/lib/*solr*

...this is probably a show stopper that will require a new RC.  

having multiple versions of the jar could easily break things with
class incompatibilities depending on what version they get loaded in
by the classloader. 

(FWIW: all of the "solr" jars are all suppose to be in "dist" ... but
it looks like that dir is where the apache-solr-velocity jar was in
1.4.0 as well so probably not something we should change in this


the example has an uncompressed war, a request log file, and
an already constructed index in it...

Only in tgz/apache-solr-1.4.1/example/logs: 2010_06_16.request.log
Only in tgz/apache-solr-1.4.1/example/solr: data
Only in tgz/apache-solr-1.4.1/example/work: 

...these aren't suppose to be there (but probably don't hurt much)


version info says...

Solr Implementation Version: 1.4.1 954930M - mark - 2010-06-15 11:23:44

...that "M" indicates local modifications.  it's not really a blocker,
but ideally the build should be from a known reproducable state of
SVN (ie: since it looks like we may do another release candidate,
let's make sure it's an unmodified checkout, but it's not a huge deal)



To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message