lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] Commented: (LUCENE-2311) Pass potent SR to IRWarmer.warm(), and also call warm() for new segments
Date Tue, 01 Jun 2010 21:36:37 GMT


Michael McCandless commented on LUCENE-2311:

bq. From the user's standpoint warming up a new-from-scratch segment and warming up just-merged
segment is the same action. 

OK, I agree... but, let's open a separate issue to rename
setMergedSegmentWarmer -> setSegmentWarmer, and have it be invoked for
flushed and merged segments?

Does your pending patch (what's the issue number again?) do this already?

I agree this change isn't needed for 2.9.3.

bq. I think there is no hurry to push the fix for this into 2.9.3. 

I think the first part of this bug (that you get an impotent
SegmentReader passed to your segment warmer) should be fixed for
2.9.3.  The fix is trivial.

> Pass potent SR to IRWarmer.warm(), and also call warm() for new segments
> ------------------------------------------------------------------------
>                 Key: LUCENE-2311
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Earwin Burrfoot
>            Assignee: Michael McCandless
>             Fix For: 2.9.3, 3.0.2, 3.1, 4.0
>         Attachments: LUCENE-2311.patch, LUCENE-2311.patch
> Currently warm() receives a SegmentReader without terms index and docstores.
> It would be arguably more useful for the app to receive a fully loaded reader, so it
can actually fire up some caches. If the warmer is undefined on IW, we probably leave things
as they are.
> It is also arguably more concise and clear to call warm() on all newly created segments,
so there is a single point of warming readers in NRT context, and every subreader coming from
getReader is guaranteed to be warmed up -> you don't have to introduce even more mess in
your code by rechecking it.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message