lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Erik Hatcher <erik.hatc...@gmail.com>
Subject Re: [VOTE] Release Solr 1.4.1
Date Thu, 17 Jun 2010 10:59:02 GMT

On Jun 16, 2010, at 7:00 PM, Chris Hostetter wrote:
> --
>
> I'm seeing multiple velocity contrib jars w/odd file names...
>
> $ ls contrib/velocity/src/main/solr/lib/*solr*
> contrib/velocity/src/main/solr/lib/apache-solr-velocity-1.4.1-dev.jar
> contrib/velocity/src/main/solr/lib/apache-solr-velocity-1.4.1.jar
> contrib/velocity/src/main/solr/lib/apache-solr-velocity-1.4.2-dev.jar
> contrib/velocity/src/main/solr/lib/apache-solr-velocity-X.Y.M.jar
>
> ...this is probably a show stopper that will require a new RC.
>
> having multiple versions of the jar could easily break things with
> class incompatibilities depending on what version they get loaded in
> by the classloader.

A change was made on trunk to contrib/velocity/build.xml to clean up  
these old JARs:

   <target name="clean">
   	<delete failonerror="false" dir="target"/>
   	<delete>
   	  <fileset dir="src/main/solr/lib" includes="apache-solr-velocity- 
*.jar"/>
   	</delete>
   </target>

It's not on branch-1.4 though.  Should it be?  But at the very least,  
indeed those apache-solr-velocity-*.jar should be removed prior to a  
build.

> (FWIW: all of the "solr" jars are all suppose to be in "dist" ... but
> it looks like that dir is where the apache-solr-velocity jar was in
> 1.4.0 as well so probably not something we should change in this
> release)

Noted - I'll fix this as VrW is moved to core.

	Erik


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message