lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2488) Fix 2.9 contrib builds to succeed when JDK 1.4 is used (leaving out contribs that require 1.5)
Date Sat, 05 Jun 2010 05:18:27 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875862#action_12875862
] 

Uwe Schindler commented on LUCENE-2488:
---------------------------------------

Hi Robert,

in Lucene 2.9, it was intended to work like this, as this code is already there, but the recent
added contribs did not use the property at all! Lucene 2.9 is Java 1.4, so it *must* compile,
if you run it with this JDK version.

Without this, it's impossible to check the dependency correctly, and because of this I *fixed*
this. I dont want to commit this in 3.x or trunk! So please just tell, if you are fine with
*fixing* it in Lucebe 2.9, so it works as expected!

bq. This patch can be ported to 3.x or trunk, when 1.6 contribs will appear.

This patch is for Lucene 2.9 branch only!

> Fix 2.9 contrib builds to succeed when JDK 1.4 is used (leaving out contribs that require
1.5)
> ----------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-2488
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2488
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 2.9, 2.9.1, 2.9.2
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 2.9.3
>
>         Attachments: LUCENE-2488.patch
>
>
> When you build and test Lucene 2.9 with Java 1.4, building and testing of contrib fails.
This patch fixes this to repect the current compiler version and disables all contribs that
need Java 1.5 by checking their javac.source property.
> This patch can be ported to 3.x or trunk, when 1.6 contribs will appear.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message