lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2311) Pass potent SR to IRWarmer.warm(), and also call warm() for new segments
Date Wed, 02 Jun 2010 15:17:40 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874606#action_12874606
] 

Michael McCandless commented on LUCENE-2311:
--------------------------------------------

OK I opened LUCENE-2485 for the 2nd part of this issue.

I'll commit the first part shortly.

> Pass potent SR to IRWarmer.warm(), and also call warm() for new segments
> ------------------------------------------------------------------------
>
>                 Key: LUCENE-2311
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2311
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Earwin Burrfoot
>            Assignee: Michael McCandless
>             Fix For: 2.9.3, 3.0.2, 3.1, 4.0
>
>         Attachments: LUCENE-2311.patch, LUCENE-2311.patch
>
>
> Currently warm() receives a SegmentReader without terms index and docstores.
> It would be arguably more useful for the app to receive a fully loaded reader, so it
can actually fire up some caches. If the warmer is undefined on IW, we probably leave things
as they are.
> It is also arguably more concise and clear to call warm() on all newly created segments,
so there is a single point of warming readers in NRT context, and every subreader coming from
getReader is guaranteed to be warmed up -> you don't have to introduce even more mess in
your code by rechecking it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message