lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Updated: (LUCENE-2488) Fix 2.9 contrib builds to succeed when JDK 1.4 is used (leaving out contribs that require 1.5)
Date Sat, 05 Jun 2010 07:52:27 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Uwe Schindler updated LUCENE-2488:
----------------------------------

    Attachment: LUCENE-2488.patch

More ant magic.

This patch does not automatically exclude 1.5 only contribs, it fails per default with an
error message:

{noformat}
Buildfile: build.xml
     [echo] Building fast-vector-highlighter...

javacc-uptodate-check:

javacc-notice:

jflex-uptodate-check:

jflex-notice:

common.init:

fail-jdk14-version:

BUILD FAILED
contrib-build.xml:98: Contrib 'fast-vector-highlighter' needs at least JDK 1.5 to build. If
you only want to compile Java 1.4 compatible contribs, add '-Dforce.jdk14.build=true' to command
line.

Total time: 0 seconds
{noformat}

For testing a whole "ant test" with JDK 1.4 you can pass the mentioned property, so it excludes
als Java 1.5 contribs. With this its possible for me as release manager of 2.9, to test compatibility
with Java 1.4.

Robert, are you fine with that for 2.9.3? If we need something similar in trunk, we *may*
think about adding a similar ant magic to the trunk/3x build scripts. But this is not part
of this issue, this is fix for 2.9.3 only.

> Fix 2.9 contrib builds to succeed when JDK 1.4 is used (leaving out contribs that require
1.5)
> ----------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-2488
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2488
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 2.9, 2.9.1, 2.9.2
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 2.9.3
>
>         Attachments: LUCENE-2488.patch, LUCENE-2488.patch
>
>
> When you build and test Lucene 2.9 with Java 1.4, building and testing of contrib fails.
This patch fixes this to repect the current compiler version and disables all contribs that
need Java 1.5 by checking their javac.source property.
> This patch can be ported to 3.x or trunk, when 1.6 contribs will appear.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message