lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2511) OutOfMemoryError should not be wrapped in an IllegalStateException, as it is misleading for fault-tolerant programs
Date Fri, 25 Jun 2010 10:59:50 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882530#action_12882530
] 

Michael McCandless commented on LUCENE-2511:
--------------------------------------------

Did you mean Lucene 2.4.1?

If you never saw the OOME then that's really a bug.  We try hard to throw the original OOME...
and then record in IW that an OOME was hit so that we don't try to commit.

Note that we do not wrap/suppress an OOME during commit; rather, we check IW to see if any
ops against it had hit OOME, and then throw the ISE.  If you really hit an OOME during commit,
Lucene should throw that back to you too.

What ops is your single thread invoking on IW?  We can scrutinize those methods to see if
somewhere they may suppress OOME, but we try not to do that.

> OutOfMemoryError should not be wrapped in an IllegalStateException, as it is misleading
for fault-tolerant programs
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-2511
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2511
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>    Affects Versions: 2.4.1
>            Reporter: David Sitsky
>            Priority: Minor
>
> I have a program, which does explicit commits.  On one occasion, I saw the following
exception thrown:
> java.lang.IllegalStateException: this writer hit an OutOfMemoryError; cannot commit
> at org.apache.lucene.index.IndexWriter.prepareCommit(IndexWriter.java:4061)
> at org.apache.lucene.index.IndexWriter.commit(IndexWriter.java:4136)
> at org.apache.lucene.index.IndexWriter.commit(IndexWriter.java:4114)
> In our program, we treat all errors as fatal and terminate the program (and restart).
 Runtime exceptions are sometimes handled differently, since they are usually indicative of
a programming bug that might be recoverable. in some situations.
> I think the OutOfMemoryError should not be wrapped as a runtime exception.. as this can
mask a serious issue from a fault-tolerant application.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message