lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <>
Subject [jira] Issue Comment Edited: (SOLR-1969) Make MMapDirectory configurable in solrconfig.xml
Date Sun, 27 Jun 2010 09:36:50 GMT


Uwe Schindler edited comment on SOLR-1969 at 6/27/10 5:35 AM:

Also we are using Java5, so please use the varargs feature in Arrays.asList().

I don't understand the static "fileTypes" variable at all. It's static but not used anywhere
in the code. And why it is wrapped into an ArrayList at all? it does not need to be modified,
so the resulting List from Arrays.asList is fair enough. You can reduce the whole patch to
a class with a maximum of about 10 lines of code.

And yes, there is a list of extensions in Lucene (but unfortunately not in trunk, as trunk
can have very different file extensions as it uses flex. The list is only available through
the used codec when you open the index)!

Please upload patches as .patch files, this makes it easier to review as they open in patch
viewer outside of browser.

      was (Author: thetaphi):
    Also we are using Java5, so please use the varargs feature in Arrays.asList().
> Make MMapDirectory configurable in solrconfig.xml
> -------------------------------------------------
>                 Key: SOLR-1969
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.4
>            Reporter: Stephen Bochinski
>         Attachments: mmap_upd.txt, mmap_upd.txt
>   Original Estimate: 102.5h
>  Remaining Estimate: 102.5h
> This will make it so you can enable mmapdirectory from the solrconfig.xml file. There
are also several configurations you can specify in the solrconfig.xml file. You can enable
or disable the unmapping files which have been closed by solr. This is almost necessary for
an index which is being optimized. You also have the option to not mmap certain files. In
this case, FSDirectory will be used to manage those particular files. This is particularly
useful if you are using FieldCache (SOLR-1961). Having this enabled makes it useless to memory
map the .fdt and .fdx files, considering they are already in memory.
> The configurations are specified as follows:
> <directoryFactory class="solr.MMapDirectoryFactory">
>     <str name="unmap">true</str>
>     <lst name="filetypes">
>       <bool name="fdt">false</bool>
>       <bool name="fdx">false</bool>
>     </lst>
>   </directoryFactory>
> This would enable unmapping of closed files and would not memory map files ending with
.fdt and .fdx.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message