Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Received-SPF: pass (nike.apache.org: domain of rcmuir@gmail.com designates
 209.85.218.222 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :content-type;
        b=lSSp11CA8yDBX3XdY2tiYqKPztWUpdYFcFGnN8+DDZTQnXY7UiQ823RXipzAJdlRyA
         ZU8kFkCL/XAsAt7oMN+/lGTdt2QSypNqXi5qygCGQvH+W3utggn2QmUvtLV6qljxIckZ
         EIIO0APBmla/qf6I45LE3fbv5gy4tLXLdaALU=
MIME-Version: 1.0
In-Reply-To: <u2gc68e39171005030555p9654e543kb8b6a183b9b0390f@mail.gmail.com>
References: <o2wc68e39171005021032vef44d155l89eeffea5f650b07@mail.gmail.com>
	<g2x9ac0c6aa1005030236nd4a6325cw34bc74a319e4f2d1@mail.gmail.com>
	<r2l786fde51005030315k3a452879s4cd7cec58f7b364b@mail.gmail.com>
	<y2z9ac0c6aa1005030330n90a317d4u33fc4da50a10a0ae@mail.gmail.com>
	<u2gc68e39171005030555p9654e543kb8b6a183b9b0390f@mail.gmail.com>
From: Robert Muir <rcmuir@gmail.com>
Date: Mon, 3 May 2010 09:02:36 -0400
Message-ID: <z2q8f0ad1f31005030602he12faa8aq854e3868773af972@mail.gmail.com>
Subject: Re: BytesRef comparable
To: dev@lucene.apache.org, yonik@lucidimagination.com
Content-Type: multipart/alternative; boundary=00032555a2522bd3ba0485b036bb

--00032555a2522bd3ba0485b036bb
Content-Type: text/plain; charset=UTF-8

On Mon, May 3, 2010 at 8:55 AM, Yonik Seeley <yonik@lucidimagination.com>wrote:

>
> I thought we were going to be changing lucene's index order to the
> natural byte order (same as the unicode code point order)?
>
> Solr's BoundedTreeSet doesn't take a comparator.  I could change it so
> that it could of course... but it just seemed natural to "fix"
> BytesRef.
>
>
In my opinion, BytesRef should be comparable, with the default being
'natural' (unsigned/codepoint order).
And you can still specify a crazy comparator in your codec, but not all
things would work (its an expert customization)

I mean, things like automaton won't work if you change the sort order to
something wacky anyway... so theres nothing strange about Solr's
BoundedTreeSet not using a custom codec comparator?

-- 
Robert Muir
rcmuir@gmail.com

--00032555a2522bd3ba0485b036bb
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<br><br><div class=3D"gmail_quote">On Mon, May 3, 2010 at 8:55 AM, Yonik Se=
eley <span dir=3D"ltr">&lt;<a href=3D"mailto:yonik@lucidimagination.com">yo=
nik@lucidimagination.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmai=
l_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left=
:1ex;">

<div class=3D"im"><br>
</div>I thought we were going to be changing lucene&#39;s index order to th=
e<br>
natural byte order (same as the unicode code point order)?<br>
<br>
Solr&#39;s BoundedTreeSet doesn&#39;t take a comparator. =C2=A0I could chan=
ge it so<br>
that it could of course... but it just seemed natural to &quot;fix&quot;<br=
>
BytesRef.<br>
<div><div></div><div class=3D"h5"><br></div></div></blockquote><div><br></d=
iv><div>In my opinion, BytesRef should be comparable, with the default bein=
g &#39;natural&#39; (unsigned/codepoint order).</div><div>And you can still=
 specify a crazy comparator in your codec, but not all things would work (i=
ts an expert customization)</div>

<div><br></div><div>I mean, things like automaton won&#39;t work if you cha=
nge the sort order to something wacky anyway... so theres nothing strange a=
bout Solr&#39;s BoundedTreeSet not using a custom codec comparator?=C2=A0</=
div>

</div><br>-- <br>Robert Muir<br><a href=3D"mailto:rcmuir@gmail.com">rcmuir@=
gmail.com</a><br>

--00032555a2522bd3ba0485b036bb--