Return-Path: Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: (qmail 10534 invoked from network); 14 May 2010 23:48:14 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 14 May 2010 23:48:14 -0000 Received: (qmail 4139 invoked by uid 500); 14 May 2010 23:48:13 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 4090 invoked by uid 500); 14 May 2010 23:48:13 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 4083 invoked by uid 99); 14 May 2010 23:48:13 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 May 2010 23:48:13 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=10.0 tests=AWL,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [208.69.42.181] (HELO radix.cryptio.net) (208.69.42.181) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 May 2010 23:48:08 +0000 Received: by radix.cryptio.net (Postfix, from userid 1007) id 1FEE471C090; Fri, 14 May 2010 16:47:48 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by radix.cryptio.net (Postfix) with ESMTP id 1D65971C078; Fri, 14 May 2010 16:47:48 -0700 (PDT) Date: Fri, 14 May 2010 16:47:48 -0700 (PDT) From: Chris Hostetter To: Mark Miller cc: Lucene Dev Subject: Re: [jira] Updated: (SOLR-1846) Remove support for (broken) abortOnConfigurationError In-Reply-To: <6241959.57631273880743541.JavaMail.jira@thor> Message-ID: References: <6241959.57631273880743541.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mark: will it cause you cloud merging problems if i commit this? : Date: Fri, 14 May 2010 19:45:43 -0400 (EDT) : From: "Hoss Man (JIRA)" : Reply-To: dev@lucene.apache.org : To: dev@lucene.apache.org : Subject: [jira] Updated: (SOLR-1846) Remove support for (broken) : abortOnConfigurationError : : : [ https://issues.apache.org/jira/browse/SOLR-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] : : Hoss Man updated SOLR-1846: : --------------------------- : : Attachment: SOLR-1846.patch : : updated patch to included the above mentioned suggestions for BadIndexSchemaTest ... it's actually a lot easier now that we have SolrTestCaseJ4 : : As part of this, i also enhanced AbstractPluginLoader to include the getMessage() from the exception it wraps in it's own message -- this made the test easier to write, but also seems like a good idea in general (prior to this patch the exception messages just told you what type of plugin had a problem being initialized, and you had to look at the nested exception to see why it had a problem) : : > Remove support for (broken) abortOnConfigurationError : > ----------------------------------------------------- : > : > Key: SOLR-1846 : > URL: https://issues.apache.org/jira/browse/SOLR-1846 : > Project: Solr : > Issue Type: Improvement : > Reporter: Hoss Man : > Attachments: SOLR-1846.patch, SOLR-1846.patch : > : > : > Setting abortOnConfigurationError==false has not worked for some time, and based on a POLL of existing users, no one seems to need/want it, so we should remove support for it completely to make error handling and reporting work more cleanly. : > http://n3.nabble.com/POLL-Users-of-abortOnConfigurationError-tt484030.html#a484030 : : -- : This message is automatically generated by JIRA. : - : You can reply to this email to add a comment to the issue online. : : : --------------------------------------------------------------------- : To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org : For additional commands, e-mail: dev-help@lucene.apache.org : -Hoss --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org