Return-Path: Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: (qmail 50309 invoked from network); 30 May 2010 14:40:59 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 30 May 2010 14:40:59 -0000 Received: (qmail 51529 invoked by uid 500); 30 May 2010 14:40:58 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 51475 invoked by uid 500); 30 May 2010 14:40:58 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 51468 invoked by uid 99); 30 May 2010 14:40:58 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 30 May 2010 14:40:58 +0000 X-ASF-Spam-Status: No, hits=-1480.3 required=10.0 tests=ALL_TRUSTED,AWL X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 30 May 2010 14:40:57 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o4UEebmU025581 for ; Sun, 30 May 2010 14:40:37 GMT Message-ID: <29765106.72761275230437552.JavaMail.jira@thor> Date: Sun, 30 May 2010 10:40:37 -0400 (EDT) From: "Michael McCandless (JIRA)" To: dev@lucene.apache.org Subject: [jira] Updated: (LUCENE-2104) IndexWriter.unlock does does nothing if NativeFSLockFactory is used MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-2104: --------------------------------------- Fix Version/s: 2.9.3 3.0.2 > IndexWriter.unlock does does nothing if NativeFSLockFactory is used > ------------------------------------------------------------------- > > Key: LUCENE-2104 > URL: https://issues.apache.org/jira/browse/LUCENE-2104 > Project: Lucene - Java > Issue Type: Bug > Components: Store > Affects Versions: 2.9, 2.9.1, 3.0 > Reporter: Shai Erera > Assignee: Uwe Schindler > Priority: Minor > Fix For: 2.9.3, 3.0.2, 3.1, 4.0 > > Attachments: LUCENE-2104.patch, LUCENE-2104.patch, LUCENE-2104.patch > > > If NativeFSLockFactory is used, IndexWriter.unlock will return, silently doing nothing. The reason is that NativeFSLockFactory's makeLock always creates a new NativeFSLock. NativeFSLock's release first checks if its lock is not null. However, only if obtain() is called, that lock is not null. So release actually does nothing, and so IndexWriter.unlock does not delete the lock, or fail w/ exception. > This is only a problem in NativeFSLock, and not in other Lock implementations, at least as I was able to see. > Need to think first how to reproduce in a test, and then fix it. I'll work on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org