Return-Path: Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: (qmail 17695 invoked from network); 5 May 2010 19:04:25 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 5 May 2010 19:04:25 -0000 Received: (qmail 4372 invoked by uid 500); 5 May 2010 19:04:24 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 4319 invoked by uid 500); 5 May 2010 19:04:24 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 4312 invoked by uid 99); 5 May 2010 19:04:24 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 May 2010 19:04:24 +0000 X-ASF-Spam-Status: No, hits=-1393.0 required=10.0 tests=ALL_TRUSTED,AWL X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 May 2010 19:04:23 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o45J42AE001023 for ; Wed, 5 May 2010 19:04:02 GMT Message-ID: <16192594.27681273086242400.JavaMail.jira@thor> Date: Wed, 5 May 2010 15:04:02 -0400 (EDT) From: "Earwin Burrfoot (JIRA)" To: dev@lucene.apache.org Subject: [jira] Commented: (LUCENE-2447) Add support for subsets of searchables inside a MultiSearcher/ParallelMultiSearcher instance's methods at runtime In-Reply-To: <18448830.25871273081203735.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-2447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864448#action_12864448 ] Earwin Burrfoot commented on LUCENE-2447: ----------------------------------------- Is creating MultiSearcher/MultiReader per-request too heavy? I thought these were pretty lightweight. You can also stuff everything into the same index and use cached filters. > Add support for subsets of searchables inside a MultiSearcher/ParallelMultiSearcher instance's methods at runtime > ----------------------------------------------------------------------------------------------------------------- > > Key: LUCENE-2447 > URL: https://issues.apache.org/jira/browse/LUCENE-2447 > Project: Lucene - Java > Issue Type: Improvement > Components: Search > Affects Versions: 3.0.1 > Environment: Irrelevant > Reporter: Edward Drapkin > Priority: Minor > Attachments: LUCENE-2447.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > Here's the situation: We have a site with a fair few amount of indexes that we're using MultiSearcher/ParallelMultiSearcher for, but the users can select an arbitrary permutation of indexes to search. For example (contrived, but illustratory): the site has indexes numbered 1 - 10; user A wants to search in all 10; user B wants to search indexes 1, 2 and 3, user C wants to search even-numbered indexes. From Lucene 3.0.1, the only way to do this is to continually instantiate a new MultiSearcher based on every permutation of indexes that a user wants, which is not ideal at all. > What I've done is add a new parameter to all methods in MultiSearcher that use the searchables array (docFreq, search, rewrite and createDocFrequencyMap), a Set which is checked for isEmpty() and contains() for every iteration over the searchables[]. The actual logic has been moved into these methods and the old methods have become overloads that pass a Collections.emptySet() into those methods, so I do not expect there to be a very noticeable performance impact as a result of this modification, if it's measurable at all. > I didn't modify the test for MultiSearcher very much, just enough to illustrate the that subsetting of the search results works, since no other logic has changed. If I need to do more for the testing, let me know and I'll do it. > I've attached the patches for MultiSearcher.java, ParallelMultiSearcher.java and TestMultiSearcher.java. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org